Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade aws-sdk beta clients #5234

Merged
merged 3 commits into from
Mar 30, 2020
Merged

Upgrade aws-sdk beta clients #5234

merged 3 commits into from
Mar 30, 2020

Conversation

Amplifiyer
Copy link
Contributor

Issue #, if available:

Description of changes: Fixes Rekognition, Textract, Kinesis and Storage aws-sdk bugs.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #5234 into modularization will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           modularization    #5234   +/-   ##
===============================================
  Coverage           72.71%   72.71%           
===============================================
  Files                 195      195           
  Lines               11464    11464           
  Branches             2157     2233   +76     
===============================================
  Hits                 8336     8336           
+ Misses               2978     2959   -19     
- Partials              150      169   +19
Impacted Files Coverage Δ
packages/auth/src/OAuth/OAuth.ts 48.12% <0.00%> (ø)
packages/core/src/Credentials.ts 31.77% <0.00%> (ø)
packages/analytics/src/Analytics.ts 66.86% <0.00%> (ø)
packages/datastore/src/sync/outbox.ts 25.00% <0.00%> (ø)
packages/datastore/src/storage/storage.ts 67.59% <0.00%> (ø)
packages/core/src/OAuthHelper/GoogleOAuth.ts 32.65% <0.00%> (ø)
packages/xr/src/Providers/SumerianProvider.ts 47.55% <0.00%> (ø)
packages/core/src/OAuthHelper/FacebookOAuth.ts 35.55% <0.00%> (ø)
packages/datastore/src/sync/processors/sync.ts 17.33% <0.00%> (ø)
...ackages/datastore/src/storage/adapter/indexeddb.ts 73.26% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31a273e...4aa3aec. Read the comment docs.

sammartinez
sammartinez approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@sammartinez sammartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one callout that is NON BLOCKING so wanted to Approve

packages/analytics/package.json
"@aws-sdk/client-kinesis": "1.0.0-beta.1",
"@aws-sdk/client-personalize-events": "1.0.0-beta.1",
"@aws-sdk/client-pinpoint": "1.0.0-beta.1",
"@aws-sdk/client-firehose": "1.0.0-beta.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future thinking, are we going to look to just have a ^ for newer versions? I understand the need for it now but was seeing what we are thinking on this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, going forward we do want loose version numbers to avoid having duplicate package versions in client's app. but currently we can't risk it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

@Amplifiyer Amplifiyer merged commit 21a00b4 into modularization Mar 30, 2020
This was referenced Dec 24, 2020
Open
Merged
Open
Open
This was referenced Jan 14, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Jan 15, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Merged
Open
Open
Open
Open
Open
Open
Open
Open
Open
@sitedata sitedata mentioned this pull request Jan 26, 2021
Open
@sitedata sitedata mentioned this pull request Feb 3, 2021
Open
@0xpixel 0xpixel mentioned this pull request Feb 9, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Mar 27, 2021
Open
This was referenced May 14, 2021
Open
Open
Open
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2021
@jimblanc jimblanc deleted the modularization-Amplifiyer branch November 23, 2022 15:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sammartinez sammartinez sammartinez approved these changes

@jordanranz jordanranz Awaiting requested review from jordanranz

@manueliglesias manueliglesias Awaiting requested review from manueliglesias

@iartemiev iartemiev Awaiting requested review from iartemiev

Assignees

@Amplifiyer Amplifiyer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Amplifiyer @sammartinez